Datepicker: allows the correct use of 0-99 years,#1262
Closed
BrunoRB wants to merge 2 commits intojquery:masterfrom
Closed
Datepicker: allows the correct use of 0-99 years,#1262BrunoRB wants to merge 2 commits intojquery:masterfrom
BrunoRB wants to merge 2 commits intojquery:masterfrom
Conversation
Fixes the problem where the years [0-99] were being converted to [1900-1999]. Fixes #7098.
|
Any news on this one? |
Member
|
Thanks for the patch. Unfortunately, large changes to datepicker tend to result in unforeseen regressions. Since we have a lot of work done on the datepicker rewrite already, we'll just wait for that to fix the bug. |
|
This is a known bug which has been open for years, with a valid patch that was submitted according to your guidelines and that passes your tests. It makes no sense to just sweep it under the rug :( |
This was referenced Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7098, http://bugs.jqueryui.com/ticket/7098.
The cause of the bug is relatively simple, javascript date constructor cast 0-99 years to 1900-1999. In order to fix this I had to introduce the "_getDateObjectWithFixedYear" function and change all the "new Date(year, month, day)" calls to this new function.
Also, this fix only applies when "shortYearCutoff" is setted to 0.